Skip to content

Conversation

japaric
Copy link
Contributor

@japaric japaric commented Apr 30, 2018

this attribute has no effect on other items. This makes the implementation match what's described in the RFC.

cc #40289

r? @nagisa

@pietroalbini pietroalbini added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 30, 2018
@nagisa
Copy link
Member

nagisa commented Apr 30, 2018

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 30, 2018

📌 Commit bd4ebf2 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 30, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Apr 30, 2018
check that #[used] is used only on statics

this attribute has no effect on other items. This makes the implementation match what's described in the RFC.

cc rust-lang#40289

r? @nagisa
bors added a commit that referenced this pull request Apr 30, 2018
Rollup of 7 pull requests

Successful merges:

 - #50233 (Make `Vec::new` a `const fn`)
 - #50312 (Add more links in panic docs)
 - #50316 (Fix some broken links in docs.)
 - #50325 (Add a few more tests for proc macro feature gating)
 - #50327 (Display correct unused field suggestion for nested struct patterns)
 - #50330 (check that #[used] is used only on statics)
 - #50344 (Update Cargo to 2018-04-28 122fd5be5201913d42e219e132d6569493583bca)

Failed merges:
@bors bors merged commit bd4ebf2 into rust-lang:master Apr 30, 2018
@japaric japaric deleted the used branch May 1, 2018 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants